Github user ioana-delaney commented on a diff in the pull request:
https://github.com/apache/spark/pull/17546#discussion_r111192197
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/CostBasedJoinReorder.scala
---
@@ -150,12 +148,15 @@ object JoinReorderDP extends PredicateHelper with
Logging {
case (item, id) => Set(id) -> JoinPlan(Set(id), item, Set(), Cost(0,
0))
}.toMap)
+ // Build filters from the join graph to be used by the search
algorithm.
+ val filters = JoinReorderDPFilters.buildJoinGraphInfo(conf, items,
conditions, itemIndex)
--- End diff --
@cloud-fan I call it "filters" since the join graph information is used as
filters on top of the DP join enumeration. It suggests the purpose for which
the graph info was gathered.
If this is confusing, I can rename. Let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
