Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17495#discussion_r111213398
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -320,14 +321,35 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
.filter { entry =>
try {
val prevFileSize =
fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
+
+ def canAccess = {
--- End diff --
Return type? Also I'd make this a top-level method (with the entry and
action as parameters), maybe even in `SparkHadoopUtil`... just to avoid the
deeply-nested method declaration. That allows you to easily write a unit test
for it (yay!).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
