Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17495#discussion_r111213925
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -320,14 +321,35 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
.filter { entry =>
try {
val prevFileSize =
fileToAppInfo.get(entry.getPath()).map{_.fileSize}.getOrElse(0L)
+
+ def canAccess = {
+ val perm = entry.getPermission
+ val ugi = UserGroupInformation.getCurrentUser
+ val user = ugi.getShortUserName
+ val groups = ugi.getGroupNames
+ if (user == entry.getOwner &&
perm.getUserAction.implies(FsAction.READ)) {
+ true
+ } else if (groups.contains(entry.getGroup) &&
+ perm.getGroupAction.implies(FsAction.READ)) {
+ true
+ } else if (perm.getOtherAction.implies(FsAction.READ)) {
+ true
+ } else {
+ throw new AccessControlException(s"Permission denied:
user=$user, " +
--- End diff --
Why throw an exception instead of returning false? That makes the
function's interface weird.
You could just log the access issue here if you want, and then you can even
remove the `try..catch`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
