Github user Krimit commented on a diff in the pull request: https://github.com/apache/spark/pull/17673#discussion_r113599047 --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Word2Vec.scala --- @@ -127,6 +150,11 @@ final class Word2Vec @Since("1.4.0") ( @Since("1.4.0") override val uid: String) extends Estimator[Word2VecModel] with Word2VecBase with DefaultParamsWritable { + private val batchSize = 10000 + private val power = 0.75 + private val maxUnigramTableSize = 100*1000*1000 + private val unigramTableSizeFactor = 20 --- End diff -- Please add some comments describing these values. Should any of them be tune-able?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org