Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12004#discussion_r113750071
  
    --- Diff: pom.xml ---
    @@ -1145,6 +1150,70 @@
               </exclusion>
             </exclusions>
           </dependency>
    +      <!--
    +        the AWS module pulls in jackson; its transitive dependencies can 
create
    +        intra-jackson-module version problems.
    +        -->
    +      <dependency>
    --- End diff --
    
    I'm declaring them here purely as declarations, so there's one place where 
all the hadoop dependencies go, versions declared etc. The cloud POM explicitly 
adds them to the module dependency, so that's the only place where they get 
pulled into the build. It's similar to what's done with Hive: spark-hive 
declares the actual dependencies, but the root pom declares what hive version 
to pull in, and what stuff to leave out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to