Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/12004#discussion_r113725132
--- Diff: assembly/pom.xml ---
@@ -226,5 +226,19 @@
<parquet.deps.scope>provided</parquet.deps.scope>
</properties>
</profile>
+
+ <!--
+ Pull in spark-hadoop-cloud and its associated JARs,
+ -->
+ <profile>
+ <id>cloud</id>
--- End diff --
so org/apache/spark + hadoop-cloud? I'll cause too much confusion were any
JAR created thrown into a lib/ directory; you'd get
```
hadoop-aws-2.8.1.jar
spark-core-2.3.0
hadoop-cloud-2.3.0
```
& people would be trying to understand why the hadoop-* was out of sync,
who to ping, etc.
There's actually a [hadoop-cloudproject
POM](https://github.com/apache/hadoop/blob/trunk/hadoop-cloud-storage-project/hadoop-cloud-storage/pom.xml)
coming in hadoop-trunk to try and be a one-stop-dependency for all cloud
bindings (avoiding the ongoing "declare new dependencies per version"). the
names are way too close.
I'd had it as spark-cloud, you'd felt spark-hadoop-cloud was better. I
can't think of what else would do, but I do think spark- is the string which
should go at the front
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
