Github user sameeragarwal commented on a diff in the pull request: https://github.com/apache/spark/pull/17821#discussion_r114206001 --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala --- @@ -266,7 +282,7 @@ private[deploy] class Worker( if (registerMasterFutures != null) { registerMasterFutures.foreach(_.cancel(true)) } - val masterAddress = masterRef.address + val masterAddress = masterAddressToConnect.get --- End diff -- How about we conf protect this change (with a default that still uses `masterRef`). If we can merge `master` and `masterAddress` as I suggested above, we can just add a conf on the master and the worker code can be largely unaffected.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org