Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/17821#discussion_r114205566
--- Diff: core/src/main/scala/org/apache/spark/deploy/DeployMessage.scala
---
@@ -80,8 +91,16 @@ private[deploy] object DeployMessages {
sealed trait RegisterWorkerResponse
- case class RegisteredWorker(master: RpcEndpointRef, masterWebUiUrl:
String) extends DeployMessage
- with RegisterWorkerResponse
+ /**
+ * @param master the master ref
+ * @param masterWebUiUrl the master Web UI address
+ * @param masterAddress the master address used by the worker to
connect. It should be
+ * [[RegisterWorker.masterAddress]].
+ */
+ case class RegisteredWorker(
+ master: RpcEndpointRef,
+ masterWebUiUrl: String,
+ masterAddress: RpcAddress) extends DeployMessage with
RegisterWorkerResponse
--- End diff --
Can we avoid adding an extra field here? Perhaps just put the
`masterAddress` in the `master` field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
