Github user zero323 commented on a diff in the pull request: https://github.com/apache/spark/pull/17825#discussion_r114457011 --- Diff: R/pkg/R/column.R --- @@ -132,17 +132,24 @@ createMethods() #' alias #' -#' Set a new name for a column +#' Set a new name for an object. Equivalent to SQL "AS" keyword. --- End diff -- Moving to `generics.R` sounds good. "Column or SparkDataFrame" in place of "object" as well. Regarding "AS"... In SQL it can be used with both expressions and tables so I deliberately didn't quantify this with `Column`. I am not sure if we really need to state that it returns a new object. Maybe _Return a new Column or SparkDataFrame with an alias. Equivalent to SQL "AS" keyword._? But it doesn't sound great.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org