Github user zero323 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17825#discussion_r114687096
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -3715,3 +3715,25 @@ setMethod("rollup",
                 sgd <- callJMethod(x@sdf, "rollup", jcol)
                 groupedData(sgd)
               })
    +
    +#' alias
    +#'
    +#' @aliases alias,SparkDataFrame-method
    +#' @rdname alias
    +#' @name alias
    +#' @examples
    --- End diff --
    
    I general it would nice to sweep all the files to make it more consistent. 
Capitalization, punctuation, examples. return and such.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to