Github user jinxing64 commented on a diff in the pull request:
https://github.com/apache/spark/pull/16989#discussion_r115522781
--- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
@@ -193,8 +206,18 @@ private[spark] object HighlyCompressedMapStatus {
} else {
0
}
+ val hugeBlockSizes = ArrayBuffer[Tuple2[Int, Byte]]()
+ if (numNonEmptyBlocks > 0) {
+ uncompressedSizes.zipWithIndex.foreach {
+ case (size, reduceId) =>
+ if (size > 2 * avgSize) {
--- End diff --
Yes, This really makes sense. How about:
1. For the minimum size, default value could be `Int.MaxValue`.
2. For the fraction, default value could be 2.
Actually, I spent quite a while for thinking this and didn't come up with
good names for these two configurations. @mridulm could you please give some
advice? And could I put this in another pr ?(I think this pr is little big now.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
