Github user jinxing64 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16989#discussion_r115525399
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/MapStatus.scala ---
    @@ -128,41 +131,60 @@ private[spark] class CompressedMapStatus(
      * @param numNonEmptyBlocks the number of non-empty blocks
      * @param emptyBlocks a bitmap tracking which blocks are empty
      * @param avgSize average size of the non-empty blocks
    + * @param hugeBlockSizes sizes of huge blocks by their reduceId.
      */
     private[spark] class HighlyCompressedMapStatus private (
         private[this] var loc: BlockManagerId,
         private[this] var numNonEmptyBlocks: Int,
         private[this] var emptyBlocks: RoaringBitmap,
    -    private[this] var avgSize: Long)
    +    private[this] var avgSize: Long,
    +    @transient var hugeBlockSizes: Map[Int, Byte])
    --- End diff --
    
    @mridulm 
    I removed the `hugeBlockSizesArray` and put `hugeBlockSizes` as transient 
in constructor. How about this now? I'm not sure how to make this as private. 
Should I move `hugeBlockSizes` from constructor into Class and create setter 
for it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to