Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17644#discussion_r116152814
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -871,6 +886,23 @@ private[hive] object HiveClientImpl {
           hiveTable.setViewOriginalText(t)
           hiveTable.setViewExpandedText(t)
         }
    +
    +    table.bucketSpec match {
    +      case Some(bucketSpec) =>
    +        hiveTable.setNumBuckets(bucketSpec.numBuckets)
    +        hiveTable.setBucketCols(bucketSpec.bucketColumnNames.toList.asJava)
    --- End diff --
    
    For data source table, which can be created by `CREATE TABLE src(...) USING 
parquet ...`, the bucketing information is in table properties, and hive will 
always read this table as a non-bucketed table.
    
    After your PR, for bucketed data source tables written by Spark, Hive will 
read them as bucketed tables and cause problems, because the bucket hashing 
function is different.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to