Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17644#discussion_r116179068 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala --- @@ -335,6 +336,32 @@ abstract class ExternalCatalog postToAll(RenameFunctionEvent(db, oldName, newName)) } + final def checkSchemaContainsBucketingColumns( --- End diff -- It will be very annoying to duplicate all checks in `SessionCatalog` and `ExternalCatalog`. I think we should put checks in `SessionCatalog` as it behaves like a front-end of `ExternalCatalog`
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org