Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17956#discussion_r116161266
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonParser.scala
---
@@ -126,16 +125,11 @@ class JacksonParser(
case VALUE_STRING =>
// Special case handling for NaN and Infinity.
- val value = parser.getText
- val lowerCaseValue = value.toLowerCase(Locale.ROOT)
- if (lowerCaseValue.equals("nan") ||
- lowerCaseValue.equals("infinity") ||
- lowerCaseValue.equals("-infinity") ||
- lowerCaseValue.equals("inf") ||
- lowerCaseValue.equals("-inf")) {
- value.toFloat
--- End diff --
Probably let me check and open JIRA/PR if there are some cases we should
handle when I have some time. Let's leave out that here. It sounds that does
not block this PR and I don't want extra changes do not hold off this PR like
https://github.com/apache/spark/pull/17901.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
