Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17956#discussion_r116165105
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
 ---
    @@ -1988,4 +1988,51 @@ class JsonSuite extends QueryTest with 
SharedSQLContext with TestJsonData {
           assert(errMsg.startsWith("The field for corrupt records must be 
string type and nullable"))
         }
       }
    +
    +  test("SPARK-18772: Parse special floats correctly") {
    +    val jsons = Seq(
    +      """{"a": "+INF"}""",
    +      """{"a": "INF"}""",
    +      """{"a": "-INF"}""",
    +      """{"a": "NaN"}""",
    +      """{"a": "Infinity"}""",
    +      """{"a": "+Infinity"}""",
    +      """{"a": "-Infinity"}""")
    --- End diff --
    
    Below is from `JsonParser.Feature ALLOW_NON_NUMERIC_NUMBERS`
    
    > "INF" (for positive infinity), as well as alias of "Infinity"
    > "-INF" (for negative infinity), alias "-Infinity"
    > "NaN" (for other not-a-numbers, like result of division by zero)
    
    Then, this PR also adds `+INF` and `+Infinity`. 
    
    What is the Scala standard?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to