Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18000#discussion_r117032222 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala --- @@ -108,6 +116,15 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with SharedSQLContex checkFilterPredicate(df, predicate, filterClass, checkBinaryAnswer _, expected) } + private def checkNoFilterPredicate(predicate: Predicate)(implicit df: DataFrame): Unit = { + checkWithSelectedFilters(df, predicate) { case (_, selectedFilters) => + selectedFilters.foreach { pred => + val maybeFilter = ParquetFilters.createFilter(df.schema, pred) + assert(maybeFilter.isEmpty, s"Could generate filter predicate for $pred") --- End diff -- We should also check correctness of the results.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org