Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18000#discussion_r117061359
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -166,7 +166,14 @@ private[parquet] object ParquetFilters {
* Converts data sources filters to Parquet filter predicates.
*/
def createFilter(schema: StructType, predicate: sources.Filter):
Option[FilterPredicate] = {
- val dataTypeOf = getFieldMap(schema)
+ val nameTypeMap = getFieldMap(schema)
+
+ // Parquet does not allow dots in the column name because dots are
used as a column path
+ // delimiter. Since Parquet 1.8.2 (PARQUET-389), Parquet accepts the
filter predicates
+ // with missing columns. The incorrect results could be got from
Parquet when we push down
+ // filters for the column having dots in the names. Thus, we do not
push down such filters.
+ // See SPARK-20364.
+ def canMakeFilterOn(name: String): Boolean =
nameTypeMap.contains(name) && !name.contains(".")
--- End diff --
I think we should disallow when initially loading or writing out if it is
still allowed in any way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
