Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2509#discussion_r18018270
--- Diff: sbin/spark-daemon.sh ---
@@ -142,8 +142,12 @@ case $startStop in
spark_rotate_log "$log"
echo starting $command, logging to $log
- cd "$SPARK_PREFIX"
- nohup nice -n $SPARK_NICENESS "$SPARK_PREFIX"/bin/spark-class $command
"$@" >> "$log" 2>&1 < /dev/null &
+ if [ $command ==
"org.apache.spark.sql.hive.thriftserver.HiveThriftServer2" ]; then
+ nohup nice -n $SPARK_NICENESS "$SPARK_PREFIX"/bin/spark-submit
--class $command \
+ "${SUBMISSION_OPTS[@]}" spark-internal "${APPLICATION_OPTS[@]}" >>
"$log" 2>&1 < /dev/null &
--- End diff --
I don't think `SUBMISSION_OPTS` and `APPLICATION_OPTS` are properly defined
here. Function `gatherSparkSubmitOpts` should be called here to define these
two variables. You may refer to `sbin/start-thriftserver.sh` for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
