Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2509#discussion_r18122679
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -320,6 +320,10 @@ object SparkSubmit {
         } catch {
           case e: ClassNotFoundException =>
             e.printStackTrace(printStream)
    +        if (childMainClass.contains("thriftserver")) {
    +          println(s"Failed to load main class $childMainClass.")
    +          println("You need to build Spark with -Phive.")
    +        }
    --- End diff --
    
    After some thoughts, I think it's OK to add this checking here. Mainly 
because it avoids using the exit code checking trick, which may cause potential 
exit code conflict.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to