Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18134#discussion_r118858221
--- Diff: sql/core/src/test/resources/sql-tests/inputs/datetime.sql ---
@@ -6,3 +6,5 @@ select current_date = current_date(), current_timestamp =
current_timestamp();
select to_date(null), to_date('2016-12-31'), to_date('2016-12-31',
'yyyy-MM-dd');
select to_timestamp(null), to_timestamp('2016-12-31 00:12:00'),
to_timestamp('2016-12-31', 'yyyy-MM-dd');
+
+select dayofweek('2007-02-03'), dayofweek('2009-07-30'),
dayofweek('2017-05-27'), dayofweek(null), dayofweek('1582-10-15 13:10:15');
--- End diff --
nit: Can you add a line break at the end of file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
