Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18244#discussion_r121063884
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -126,7 +126,15 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
def set(decimal: BigDecimal): Decimal = {
this.decimalVal = decimal
this.longVal = 0L
- this._precision = decimal.precision
+ if (decimal.compare(BigDecimal(1.0)) == -1 &&
decimal.compare(BigDecimal(-1.0)) == 1) {
--- End diff --
Don't we allow the case that precision equals to scale? Seems it works for
the example expressions.
scala> sql("select floor(0.9)").show()
+----------+
|FLOOR(0.9)|
+----------+
| 0|
+----------+
scala> sql("select ceil(0.9)").show()
+---------+
|CEIL(0.9)|
+---------+
| 1|
+---------+
scala> sql("select 1 > 0.9").show()
+-----------------------+
|(CAST(1 AS BIGINT) > 0)|
+-----------------------+
| true|
+-----------------------+
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
