Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18244#discussion_r121147866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -126,7 +126,15 @@ final class Decimal extends Ordered[Decimal] with
Serializable {
def set(decimal: BigDecimal): Decimal = {
this.decimalVal = decimal
this.longVal = 0L
- this._precision = decimal.precision
+ if (decimal.compare(BigDecimal(1.0)) == -1 &&
decimal.compare(BigDecimal(-1.0)) == 1) {
--- End diff --
Btw, seems that the numbers like 0.9 are the only cases that the precision
equals to the scale. If we force precision as scale + 1, looks like we don't
support precision=scale anymore for `DecimalType`. Then we may need to update
the related check and the document in `DecimalType` which explicitly says that
scale can be equal to precision. Maybe I miss anything about this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
