Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18231#discussion_r121812049
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -151,8 +151,7 @@ public void registerExecutor(
/**
* Obtains a FileSegmentManagedBuffer from a shuffle block id. We expect
the blockId has the
- * format "shuffle_ShuffleId_MapId_ReduceId" (from ShuffleBlockId), and
additionally make
- * assumptions about how the hash and sort based shuffles store their
data.
+ * format "shuffle_ShuffleId_MapId_ReduceId" (from ShuffleBlockId).
*/
public ManagedBuffer getBlockData(String appId, String execId, String
blockId) {
--- End diff --
Is this method used anywhere else? I only see `ExternalShuffleBlockHandler`
using this class, and it now uses the new method. If only unit tests use this,
then remove this method and fix the unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
