Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18231#discussion_r121811823
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolver.java
---
@@ -164,7 +163,15 @@ public ManagedBuffer getBlockData(String appId, String
execId, String blockId) {
int shuffleId = Integer.parseInt(blockIdParts[1]);
int mapId = Integer.parseInt(blockIdParts[2]);
int reduceId = Integer.parseInt(blockIdParts[3]);
+ return getBlockData(appId, execId, shuffleId, mapId, reduceId);
+ }
+ /**
+ * Obtains a FileSegmentManagedBuffer from (shuffleId, mapId, reduceId).
We make assumptions
+ * about how the hash and sort based shuffles store their data.
+ */
+ public ManagedBuffer getBlockData(String appId, String execId, int
shuffleId, int mapId,
--- End diff --
nit: style. See constructor at top of file for the style when param lists
are long.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
