Github user jerryshao commented on a diff in the pull request: https://github.com/apache/spark/pull/18308#discussion_r122129884 --- Diff: core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala --- @@ -432,8 +432,10 @@ private[spark] class ExecutorAllocationManager( if (testing || executorsRemoved.nonEmpty) { executorsRemoved.foreach { removedExecutorId => newExecutorTotal -= 1 + val hasCachedBlocks = SparkEnv.get.blockManager.master.hasCachedBlocks(executorId); --- End diff -- Btw, there could be a chance when querying executor from BlockManager, the executor/block manager was already removed, so we will potentially get `false`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org