Github user ihazem commented on the issue:
https://github.com/apache/spark/pull/18308
@jerryshao - I pushed another commit fixing removedExecutorId and removing
';'...thx for feedback on that.
Regarding the edge case where the block manager was already removed and
could potentially get `false`. then this:
`âval timeout = if (hasCachedBlocks) cachedExecutorIdleTimeoutS else
executorIdleTimeoutS`
would just evaluate to `executorIdleTimeoutS` and wouldn't matter anyway
since executor is gone. I wonder if whether executor is completely gone or
whether executor is still there but has no cached RDD, if both scenarios return
false. That seems to be the case (unless I'm reading it wrong) based on
HasCachedBlocks in
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
