Github user danielvdende commented on a diff in the pull request:
https://github.com/apache/spark/pull/18304#discussion_r122135698
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala
---
@@ -90,6 +90,7 @@ class CSVOptions(
val quote = getChar("quote", '\"')
val escape = getChar("escape", '\\')
val comment = getChar("comment", '\u0000')
+ val lineSeparator = parameters.getOrElse("lineSeparator", "\n")
--- End diff --
Hi, thanks for pointing this out, I wasn't aware of this. Looking at it
though, how would you propose fixing this? We would need a `writerSettings`
instance to fetch the univocity default I think. Also, looking at the other
parameters, I also see hardcoded values there (for instance `val quote =
getChar("quote", '\"')`). Personally, I like the idea of being able to see the
default used directly in Spark, to prevent changes in the univocity lib from
impacting Spark usage (and requiring confusion when using).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
