Github user danielvdende commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18304#discussion_r122189644
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVOptions.scala
 ---
    @@ -90,6 +90,7 @@ class CSVOptions(
       val quote = getChar("quote", '\"')
       val escape = getChar("escape", '\\')
       val comment = getChar("comment", '\u0000')
    +  val lineSeparator = parameters.getOrElse("lineSeparator", "\n")
    --- End diff --
    
    Yeah, I did some digging, but that will probably be a lot trickier, because 
it would involve making changes in the Hadoop repo as well. For now, I've 
changed the content of this PR to only contain the hardcoding to `\n` as you 
suggested. I may take a look at the Hadoop code that would require changing as 
well, but that would require a lot more work than the scope of this story 
suggests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to