Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r122610588
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -278,6 +278,14 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
if (pyFiles != null && !isPython) {
SparkSubmit.printErrorAndExit("--py-files given but primary resource
is not a Python script")
}
+ if (totalExecutorCores != null && executorCores != null) {
--- End diff --
Think about this again, I think this part of code logic could be moved to
`SparkConf`, in case user sets these configuration via `SparkConf` object in a
programmatic way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
