Github user eatoncys commented on a diff in the pull request: https://github.com/apache/spark/pull/18322#discussion_r122676148 --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala --- @@ -543,6 +543,30 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging with Seria } } + if (contains("spark.cores.max")) { --- End diff -- @srowen Users may set these configuration via SparkConf object in a programmatic way, can I move the checkings from sparkâsubmit to here, or removed it here directly,which is better?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org