Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17865#discussion_r123182491
--- Diff: python/pyspark/sql/functions.py ---
@@ -109,15 +118,33 @@ def _():
'rint': 'Returns the double value that is closest in value to the
argument and' +
' is equal to a mathematical integer.',
'signum': 'Computes the signum of the given value.',
- 'sin': 'Computes the sine of the given value.',
+ 'sin': """Computes the sine of the given value.
+
+ :param col: :class:`DoubleType` column, units in radians.""",
'sinh': 'Computes the hyperbolic sine of the given value.',
- 'tan': 'Computes the tangent of the given value.',
+ 'tan': """Computes the tangent of the given value.
+
+ :param col: :class:`DoubleType` column, units in radians.""",
'tanh': 'Computes the hyperbolic tangent of the given value.',
- 'toDegrees': '.. note:: Deprecated in 2.1, use degrees instead.',
- 'toRadians': '.. note:: Deprecated in 2.1, use radians instead.',
+ 'toDegrees': '.. note:: Deprecated in 2.1, use :func:`degrees`
instead.',
+ 'toRadians': '.. note:: Deprecated in 2.1, use :func:`radians`
instead.',
'bitwiseNOT': 'Computes bitwise not.',
}
+_collect_list_doc = """
+ Aggregate function: returns a list of objects with duplicates.
+
+ >>> df2 = spark.createDataFrame([('Alice', 2), ('Bob', 5), ('Alice',
99)], ('name', 'age'))
+ >>> df2.agg(collect_list('name')).collect()
--- End diff --
I think we can avoid `ignore_unicode_prefix` if we call this function with
`age` for this and the one below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
