Github user map222 commented on a diff in the pull request:
https://github.com/apache/spark/pull/17865#discussion_r123912061
--- Diff: python/pyspark/sql/functions.py ---
@@ -969,8 +1005,8 @@ def months_between(date1, date2):
"""
Returns the number of months between date1 and date2.
- >>> df = spark.createDataFrame([('1997-02-28 10:30:00',
'1996-10-30')], ['t', 'd'])
- >>> df.select(months_between(df.t, df.d).alias('months')).collect()
+ >>> df = spark.createDataFrame([('1997-02-28 10:30:00',
'1996-10-30')], ['date1', 'date2'])
--- End diff --
I reverted all the other ones, but I like this one because `date1` and
`date2` match the docstring. Is that reasonable?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
