Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18421#discussion_r124177318
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -101,19 +101,30 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
* }}}
*/
override def visitAnalyze(ctx: AnalyzeContext): LogicalPlan =
withOrigin(ctx) {
- if (ctx.partitionSpec != null) {
- logWarning(s"Partition specification is ignored:
${ctx.partitionSpec.getText}")
- }
- if (ctx.identifier != null) {
+ val noscan = if (ctx.identifier != null) {
if (ctx.identifier.getText.toLowerCase(Locale.ROOT) != "noscan") {
throw new ParseException(s"Expected `NOSCAN` instead of
`${ctx.identifier.getText}`", ctx)
}
- AnalyzeTableCommand(visitTableIdentifier(ctx.tableIdentifier))
- } else if (ctx.identifierSeq() == null) {
- AnalyzeTableCommand(visitTableIdentifier(ctx.tableIdentifier),
noscan = false)
+ true
+ } else {
+ false
+ }
+
+ val partitionSpec = if (ctx.partitionSpec != null) {
+ Option(ctx.partitionSpec).map(visitNonOptionalPartitionSpec)
} else {
+ None
+ }
+
+ val table = visitTableIdentifier(ctx.tableIdentifier)
+ if (ctx.identifierSeq() == null) {
+ AnalyzeTableCommand(table, noscan, partitionSpec)
--- End diff --
`AnalyzeTableCommand(table, noscan = ctx.identifier != null, partitionSpec)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
