Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18421#discussion_r124457890
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -95,25 +95,32 @@ class SparkSqlAstBuilder(conf: SQLConf) extends
AstBuilder(conf) {
* {{{
* ANALYZE TABLE table COMPUTE STATISTICS [NOSCAN];
* }}}
+ * Example SQL for analyzing a single partition :
+ * {{{
+ * ANALYZE TABLE table PARTITION (key=value,..) COMPUTE STATISTICS
[NOSCAN];
--- End diff --
The existing syntax is not good. Could you improve them?
```SQL
ANALYZE TABLE [db_name.]tablename [PARTITION(partcol1[=val1],
partcol2[=val2], ...)]
COMPUTE STATISTICS [NOSCAN]
```
In addition, since we have a restriction, please do not call
`visitNonOptionalPartitionSpec`. Instead, we can capture the non-set partition
column and issue a more user-friendly exception message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
