Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r124733535
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/Instance.scala
---
@@ -27,3 +27,29 @@ import org.apache.spark.ml.linalg.Vector
* @param features The vector of features for this data point.
*/
private[ml] case class Instance(label: Double, weight: Double, features:
Vector)
+
+/**
+ * Case class that represents an instance of data point with
+ * label, weight, offset and features.
+ * This is mainly used in GeneralizedLinearRegression currently.
+ *
+ * @param label Label for this data point.
+ * @param weight The weight of this instance.
+ * @param offset The offset used for this data point.
+ * @param features The vector of features for this data point.
+ */
+private[ml] case class OffsetInstance(
+ label: Double,
+ weight: Double,
+ offset: Double,
+ features: Vector) {
+
+ /** Constructs from an [[Instance]] object and offset */
+ def this(instance: Instance, offset: Double = 0.0) = {
+ this(instance.label, instance.weight, offset, instance.features)
+ }
+
+ /** Converts to an [[Instance]] object by leaving out the offset. */
+ private[ml] def toInstance: Instance = Instance(label, weight, features)
--- End diff --
Remove ```private[ml]``` since you have marked the whole class as
```private[ml]```.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
