Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/17681#discussion_r125219558
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
---
@@ -590,6 +590,14 @@ class InMemoryCatalog(
catalog(db).functions.remove(funcName)
}
+ override protected def doAlterFunction(db: String, func:
CatalogFunction): Unit = synchronized {
+ requireDbExists(db)
+ requireFunctionExists(db, func.identifier.funcName)
+ catalog(db).functions.remove(func.identifier.funcName)
+ requireFunctionNotExists(db, func.identifier.funcName)
--- End diff --
It looks weird you remove a function and then require it not exists, are
you worried about removing function may be wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
