Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/17681#discussion_r125567453 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/functions.scala --- @@ -46,26 +46,47 @@ case class CreateFunctionCommand( functionName: String, className: String, resources: Seq[FunctionResource], - isTemp: Boolean) + isTemp: Boolean, + ifNotExists: Boolean, + replace: Boolean) extends RunnableCommand { + if (ifNotExists && replace) { + throw new AnalysisException("CREATE FUNCTION with both IF NOT EXISTS and REPLACE" + + " is not allowed.") + } + + // Disallows 'CREATE TEMPORARY FUNCTION IF NOT EXISTS' to be consistent + // with 'CREATE TEMPORARY FUNCTION' --- End diff -- I was asking if this is a typo... `Disallows 'CREATE TEMPORARY FUNCTION IF NOT EXISTS' to be consistent with 'CREATE TEMPORARY FUNCTION'` reads weird.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org