Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18174#discussion_r125545875
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -335,4 +335,26 @@ package object config {
"spark.")
.booleanConf
.createWithDefault(false)
+
+ private[spark] val SHUFFLE_FILE_BUFFER_SIZE =
+ ConfigBuilder("spark.shuffle.file.buffer")
+ .doc("Used to set the buffer size of outputstream in shuffle
writer.")
+ .bytesConf(ByteUnit.KiB)
+ .checkValues(Set(4, 8, 16, 32, 64, 128, 256, 512, 1024))
--- End diff --
I have modify it.
For buffer size, I think 0 is meaningless,
so I have modify for
`checkValue(v => v > 0 && v <= Int.MaxValue / 1024, ...)`
do you agree it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
