Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18174#discussion_r125546508
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
    @@ -335,4 +335,29 @@ package object config {
             "spark.")
           .booleanConf
           .createWithDefault(false)
    +
    +  private[spark] val SHUFFLE_FILE_BUFFER_SIZE =
    +    ConfigBuilder("spark.shuffle.file.buffer")
    +      .doc("Used to set the buffer size of outputstream in shuffle 
writer.")
    +      .bytesConf(ByteUnit.KiB)
    +      .checkValue(v => v > 0 && v <= Int.MaxValue / 1024,
    +        s"The file buffer size must be greater than 0 to ${Int.MaxValue / 
1024}.")
    +      .createWithDefaultString("32k")
    +
    +  private[spark] val SHUFFLE_UNSAFE_FILE_OUTPUT_BUFFER_SIZE =
    +    ConfigBuilder("spark.shuffle.unsafe.file.output.buffer")
    +      .doc("The file system for this buffer size after each partition " +
    +        "is written in unsafe shuffle writer.")
    +      .bytesConf(ByteUnit.KiB)
    +      .checkValue(v => v > 0 && v <= Int.MaxValue / 1024,
    +        s"The buffer size must be greater than 0 to ${Int.MaxValue / 
1024}.")
    +      .createWithDefaultString("32k")
    +
    +  private[spark] val SHUFFLE_DISK_WRITE_BUFFER_SIZE =
    +    ConfigBuilder("spark.shuffle.spill.diskWriteBufferSize")
    +      .doc("The buffer size to use when writing the sorted records to an 
on-disk file.")
    +      .intConf
    --- End diff --
    
    use `bytesConf` please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to