Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18555#discussion_r126315869
--- Diff:
core/src/main/scala/org/apache/spark/internal/config/package.scala ---
@@ -306,19 +396,23 @@ package object config {
"record the size accurately if it's above this config. This helps
to prevent OOM by " +
"avoiding underestimating shuffle block size when fetch shuffle
blocks.")
.bytesConf(ByteUnit.BYTE)
+ .checkValue(_ > 0, "The number of BlockThreshold event queue must
not be negative")
.createWithDefault(100 * 1024 * 1024)
private[spark] val SHUFFLE_REGISTRATION_TIMEOUT =
ConfigBuilder("spark.shuffle.registration.timeout")
.doc("Timeout in milliseconds for registration to the external
shuffle service.")
.timeConf(TimeUnit.MILLISECONDS)
+ .checkValue(_ > 0,
+ "Timeout in milliseconds for registration event queue must not be
negative")
--- End diff --
ditto. `positive`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
