Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18714#discussion_r128909042
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
 ---
    @@ -52,12 +55,22 @@ class HadoopMapReduceCommitProtocol(jobId: String, 
path: String)
        */
       @transient private var addedAbsPathFiles: mutable.Map[String, String] = 
null
     
    +  @transient private var partitionPaths: mutable.Set[String] = null
    +
    +  @transient private var stagingDir: Path = _
    --- End diff --
    
    Do you need to add these fields? It seems like they can be computed from 
`addedAbsPathFiles` and the constructor params respectively.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to