Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18714#discussion_r128921077
  
    --- Diff: 
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
 ---
    @@ -53,6 +65,18 @@ class HadoopMapReduceCommitProtocol(jobId: String, path: 
String)
       @transient private var addedAbsPathFiles: mutable.Map[String, String] = 
null
     
       /**
    +   * Tracks partitions with default path that have new files written into 
it by this task,
    +   * e.g. a=1/b=2. Files under these partitions will be saved into staging 
directory and moved to
    +   * destination directory at the end, if `runtimeOverwritePartition` is 
true.
    +   */
    +  @transient private var partitionPaths: mutable.Set[String] = null
    --- End diff --
    
    cc @ericl , `addedAbsPathFiles` only tracks partitions with custom path, we 
still need this `partitionPaths` to track partitions with default path


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to