Github user ajaysaini725 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18742#discussion_r131017418
--- Diff: python/pyspark/ml/util.py ---
@@ -61,32 +66,82 @@ def _randomUID(cls):
@inherit_doc
-class MLWriter(object):
+class BaseReadWrite(object):
+ """
+ Base class for MLWriter and MLReader. Stores information about the
SparkContext
+ and SparkSession.
+
+ .. versionadded:: 2.3.0
+ """
+
+ def __init__(self):
+ self.sparkSession = None
+
+ def context(self, sqlContext):
--- End diff --
Yeah it isn't used I just included the function definition because
JavaMLWriter which inherits from MLWriter which inherits from BaseReadWrite
uses it. I changed the function body to give a NotImplementedError though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
