Github user ajaysaini725 commented on a diff in the pull request:
https://github.com/apache/spark/pull/18742#discussion_r131028435
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -375,6 +375,18 @@ def copy(self, extra=None):
that._defaultParamMap = {}
return self._copyValues(that, extra)
+ def set(self, param, value):
+ """
--- End diff --
I included this function because the getAndSetParams function in
DefaultParamsReader required a way to set a parameter for an instance given the
param object and the value of the param. There wasn't any helper functionality
in the Params class that did this so I added the set() function from Scala. Is
it okay to leave it for this purpose or is there a better way of handling this
case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
