Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r131923383 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JacksonGenerator.scala --- @@ -202,5 +202,9 @@ private[sql] class JacksonGenerator( */ def write(array: ArrayData): Unit = writeArray(writeArrayData(array, arrElementWriter)) + def write(map: MapData, mapType: MapType): Unit = { + writeObject(writeMapData(map, mapType, makeWriter(mapType.valueType))) --- End diff -- I think we could avoid making the writer by `makeWriter(mapType.valueType))` per each map write, by creating this once when this `JacksonGenerator`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org