Github user viirya commented on the issue: https://github.com/apache/spark/pull/18875 Thanks for @HyukjinKwon detailed review. @goldmedal just one thing to be more specially, once you add new test into `sql/core/src/test/resources/sql-tests/inputs/json-functions.sql`. You can re-generate the golden file by running: SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite" -- -z json-functions.sql
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org