Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/18875#discussion_r132609949 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala --- @@ -659,13 +660,19 @@ case class StructsToJson( (arr: Any) => gen.write(arr.asInstanceOf[ArrayData]) getAndReset() + case MapType(_: DataType, _: StructType, _: Boolean) => + (map: Any) => + val mapType = child.dataType.asInstanceOf[MapType] + gen.write(map.asInstanceOf[MapData], mapType) + getAndReset() } } override def dataType: DataType = StringType override def checkInputDataTypes(): TypeCheckResult = child.dataType match { - case _: StructType | ArrayType(_: StructType, _) => + case _: StructType | ArrayType(_: StructType, _) | + MapType(_: DataType, _: StructType, _: Boolean) => --- End diff -- Is there no compatibility issue if we rename the expression? I've looked around and I think it should not be difficult to support `MapType` like `StructType`, although we needs to change few more places.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org