Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18700#discussion_r132961933
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
 ---
    @@ -1096,8 +1099,42 @@ class SessionCatalog(
        * This performs reflection to decide what type of [[Expression]] to 
return in the builder.
        */
       protected def makeFunctionBuilder(name: String, functionClassName: 
String): FunctionBuilder = {
    --- End diff --
    
    this will be overwritten by `HiveSessionCatalog`, does it mean we can not 
register spark UDAF if hive support is enable?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to