Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2595#issuecomment-57778527 LGTM. Merged into master. Thanks @chouqin , and @jkbradley and @manishamde for code review! Increasing `maxMemoryInMB` also increases the shuffle size. As long as the fix cost associated with one pass is not significant, increasing `maxMemoryInMB` might not give much performance gain.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org